CASSPYTHON-18: removed obsolete checks for python version > 3.7+#1295
CASSPYTHON-18: removed obsolete checks for python version > 3.7+#1295bschoening wants to merge 5 commits into
Conversation
| "to hang indefinitely. If you want to use the Eventlet reactor, you " | ||
| "need to install the `futurist` package to allow the driver to use " | ||
| "the GreenThreadPoolExecutor. See https://github.com/eventlet/eventlet/issues/508 " | ||
| "for more details.")) |
There was a problem hiding this comment.
So I think this was the only point left from our conversation on the prior PR @bschoening. Based on my earlier comment I'm inclined to say we should just remove this check (and executor class set operation) completely.
Whaddya think?
…ars to have fixed the issue on their side. Enables removal of futurist dependency in it's entirety.
| with self.VerifiedFunction(self, **kwargs) as vf: | ||
| fn_meta = self.keyspace_function_meta[vf.signature] | ||
| self.assertRegex(fn_meta.as_cql_query(), "CREATE FUNCTION.*\) RETURNS NULL ON NULL INPUT RETURNS .*") | ||
| self.assertRegex(fn_meta.as_cql_query(), "CREATE FUNCTION.*) RETURNS NULL ON NULL INPUT RETURNS .*") |
There was a problem hiding this comment.
I'm not trying to remember where this change (and the similar change above) came from. These tests are failing on Jenkins due to these changes... and they're failing when I run the test locally as well.
I think I made these changes and I think I convinced myself that they were okay via local runs... but something went wrong somewhere along the way.
There was a problem hiding this comment.
Oh, I think I get it... they just need to be raw strings. Working on fixing this now.
2 participants
A recreated version of #1290 (which was closed accidentally)